Handle malformed uri error in cookies #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: me <me@kentcdodds.com>
|
Cursor Agent can help with this pull request. Just |
kentcdodds
commented
Aug 16, 2025
src/index.ts
Outdated
| // Handle malformed URI gracefully by falling back to null | ||
| // This prevents crashes and allows the hint's fallback value to be used | ||
| console.warn( | ||
| `Failed to decode cookie value for ${hint.cookieName}: ${error}`, |
Member
Author
There was a problem hiding this comment.
@cursor, could we move the error to a second argument so we don't only get the toString but can also get the stack trace?
…tput Co-authored-by: me <me@kentcdodds.com>
kentcdodds
deleted the
cursor/handle-malformed-uri-error-in-cookies-d949
branch
|
🎉 This PR is included in version 1.3.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully handle malformed URI errors in client hint cookies and prevent infinite page reloads.